[tor-bugs] #34385 [Applications/Tor Browser]: Be consistent with onion service terms

[Tor Bug Tracker & Wiki]

#34385: Be consistent with onion service terms
------------------------------------------+----------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 Recently Gus, Al, and I had a conversation about whether we should use
 "onionsite" or "onion site". We decided "onion site" is better for new
 users, and that is the better option. I noticed we use "onionsite" in Tor
 Browser. We should correct those instances. Are there other terms we
 should correct?

 torbutton:
 {{{
 $ git grep -n onionsite chrome/locale/en-US/
 chrome/locale/en-US/torbutton.properties:75:onionServices.descNotFound=The
 most likely cause is that the onionsite is offline. Contact the onionsite
 administrator.
 chrome/locale/en-US/torbutton.properties:80:onionServices.descInvalid=The
 onionsite is unreachable due an internal error.
 chrome/locale/en-US/torbutton.properties:85:onionServices.introFailed=The
 most likely cause is that the onionsite is offline. Contact the onionsite
 administrator.
 chrome/locale/en-
 US/torbutton.properties:90:onionServices.rendezvousFailed=The onionsite is
 busy or the Tor network is overloaded. Try again later.
 chrome/locale/en-
 US/torbutton.properties:95:onionServices.clientAuthMissing=Access to the
 onionsite requires a key but none was provided.
 chrome/locale/en-
 US/torbutton.properties:100:onionServices.clientAuthIncorrect=The provided
 key is incorrect or has been revoked. Contact the onionsite administrator.
 chrome/locale/en-US/torbutton.properties:105:onionServices.badAddress=The
 provided onionsite address is invalid. Please check that you entered it
 correctly.
 chrome/locale/en-
 US/torbutton.properties:110:onionServices.introTimedOut=Failed to connect
 to the onionsite, possibly due to a poor network connection.
 chrome/locale/en-
 US/torbutton.properties:124:onionServices.authPreferences.dialogIntro=Keys
 for the following onionsites are stored on your computer
 }}}

 tor browser:
 {{{
 $ git grep -n onionsite browser/modules/TorStrings.jsm
 browser/modules/TorStrings.jsm:397:        dialogIntro:
 getString("authPreferences.dialogIntro", "Keys for the following
 onionsites are stored on your computer"),
 browser/modules/TorStrings.jsm:442:        "Prioritize onionsites when
 they are available."
 }}}

 Any other places?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34385>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online