[tor-bugs] #33853 [Applications/Tor Browser]: Disable What's New? feature

[Tor Bug Tracker & Wiki]

#33853: Disable What's New? feature
--------------------------------------+-----------------------------------
 Reporter:  pospeselr                 |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  ux-team                   |  Actual Points:
Parent ID:  #33534                    |         Points:
 Reviewer:                            |        Sponsor:  Sponsor58
--------------------------------------+-----------------------------------

Comment (by acat):

 Yes, by not initializing `ActivityStream` in `AboutNewTab.jsm` this should
 be disabled. The UI part seems to be implemented in `ToolbarPanelHub.jsm`
 and ` ToolbarBadgeHub.jsm`, and that's only initialized in `ASRouter.jsm`,
 which will never run with our patch.

 Not directly related, I noticed that `ToolbarPanelHub` has one usage
 outside `newtab`: https://searchfox.org/mozilla-
 beta/rev/a559a3f66b0f33306ba2ef4154660f475ae70957/browser/base/content
 /browser-siteProtections.js#1556, which adds a message to the `Protections
 Panel` but that seems unrelated to the `Whats New` panel, and should not
 affects us for now, as I think we are not planning to show the protections
 panel.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33853#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online