[tor-bugs] #33855 [Applications/Tor Browser]: Don't use site's icon as window icon in Windows when in private browsing mode

[Tor Bug Tracker & Wiki]

#33855: Don't use site's icon as window icon in Windows when in private browsing
mode
--------------------------------------+---------------------------
 Reporter:  pospeselr                 |          Owner:  tbb-team
     Type:  defect                    |         Status:  assigned
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:  #33534                    |         Points:
 Reviewer:                            |        Sponsor:  Sponsor58
--------------------------------------+---------------------------
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Replying to [comment:3 mcs]:
 > sysrqb or gk, what are your thoughts r.e. comment:2?

 Yes, I agree with that. We currently have bigger fish to fry than stubbing
 out a disabled feature like that. I guess what we can do for now, though,
 is setting the pref explicitly to `false` in our prefs file.

 That said I wonder why this is actually an issue for us at all, given that
 Mozilla likely does not want to reveal any local caching done outside of
 PBM which is then used for that feature in PBM. I feel this is either a
 non-issue (I have not looked at the code)  or something upstream wants to
 address, too, without stubbing out the function. (If the latter is the
 case we should file an upstream bug I think)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33855#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online