[tor-bugs] #33100 [Circumvention/Snowflake]: Minor Snowflake code quality improvements
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jan 29 22:14:12 UTC 2020
#33100: Minor Snowflake code quality improvements
-----------------------------------------+----------------------
Reporter: dcf | Owner: dcf
Type: enhancement | Status: assigned
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
-----------------------------------------+----------------------
More minor changes I made while working on integrating turbo tunnel code.
* initialize a global variable only once
* apply [https://blog.golang.org/package-names#TOC_3%2e naming
conventions] to the `websocketconn` package
* make `websocketconn.New` return a pointer, to directly satisfy the
`io.ReadWriteCloser` interface without needing `&`
* allow more than one simultaneous SOCKS request in the client (tor never
uses more than one, but it's how the [https://gitweb.torproject.org
/pluggable-transports/goptlib.git/tree/examples/dummy-client/dummy-
client.go?h=v1.1.0#n61 example code] and all other pluggable transport
clients work)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33100>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list