[tor-bugs] #32534 [Applications/Tor Browser]: settle on one canonical jtorctl

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jan 29 12:22:36 UTC 2020

#32534: settle on one canonical jtorctl
 Reporter:  eighthave                            |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, tbb-mobile, jtorctl,        |  Actual Points:
  TorBrowserTeam202002                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:

Comment (by akwizgran):

 Commenting here because the GitLab repo seems to have issues turned off.

 It looks like there might be a potential NPE (not caused by your changes
 @eighthave) in TorControlConnection#readReply(). The return value of
 input.readLine() at line 147 is checked for null. But when reading data
 lines at line 170 we don't check for null. It seems to me that we could
 get an NPE at line 173 if the end of the stream is reached while reading a
 multi-line reply. But I thought I'd better check before opening an MR as I
 don't understand the code or the control protocol very well.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32534#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list