[tor-bugs] #33087 [Core Tor/Tor]: closing stdio fds on exit can interfere with LeakSanitizer, etc

[Tor Bug Tracker & Wiki]

#33087: closing stdio fds on exit can interfere with LeakSanitizer, etc
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-log, 043-should, consider-       |  Actual Points:
  backport-after-0433, 041-backport,             |
  042-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  tor-log =>
     tor-log, 043-should, consider-backport-after-0433, 041-backport,
     042-backport
 * milestone:  Tor: unspecified => Tor: 0.4.3.x-final


Comment:

 I added `tor_log_close_sigsafe_err_fds()` in #31594, it was merged to
 0.4.2, and later backported to 0.4.1. I've closed #31594, so we don't
 backport it any further.

 My original motivation for the change was that some OSes seem to lose the
 last few lines of tor log output, when it crashes.

 So I suggest we change `tor_log_close_sigsafe_err_fds()` to flush those
 file descriptors, rather than closing them. (And change its name as well.)

 We'll need to backport those changes to 0.4.1 and later.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33087#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online