[tor-bugs] #31594 [Core Tor/Tor]: Close all the log fds before aborting

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jan 29 11:26:30 UTC 2020


#31594: Close all the log fds before aborting
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  diagnostics, consider-backport-      |  Actual Points:  0.9
  after-042-stable, 042-should, android, macos,  |
  041-backport, BugSmashFund                     |
Parent ID:  #31614                               |         Points:  0.3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     diagnostics, consider-backport-if-needed, consider-backport-
     after-042-stable, 042-should, android, macos, 040-backport-maybe, 041
     -backport-maybe, BugSmashFund
     =>
     diagnostics, consider-backport-after-042-stable, 042-should, android,
     macos, 041-backport, BugSmashFund
 * status:  merge_ready => closed
 * resolution:   => fixed
 * milestone:  Tor: 0.4.0.x-final => Tor: 0.4.1.x-final


Comment:

 This change caused issues for debugging using LeakSanitizer and
 AddressSanitizer in some contexts, so we should not backport it any
 further. See #33087 for more details.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31594#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list