[tor-bugs] #33029 [Core Tor/Tor]: dir-auth: Dir auths should resume sending 503's but never to relays or other dir auths

[Tor Bug Tracker & Wiki]

#33029: dir-auth: Dir auths should resume sending 503's but never to relays or
other dir auths
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  defect                   |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-dirauth 043-should?  |  Actual Points:
Parent ID:  #33018                   |         Points:  0.4
 Reviewer:  nickm, teor, armadev     |        Sponsor:
-------------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I think this patch looks good, I made a small suggestion that removes a
 few duplicate checks.

 What about the bridge authority?
 Does it need to allow bridges to post descriptors and get directory
 documents?
 If so, we need a version of nodelist_probably_contains_address() that
 contains bridge addresses.

 Replying to [comment:15 dgoulet]:
 > Now the approach is simplified. HOWEVER, because this branch only uses
 the nodelist address set, the authority will fail to recognize its fellow
 authorities as long as it doesn't have a consensus. I think that is fine
 but it might not be if anyone can think of a reason why. I can see that
 the authority is starting and gets bombarded already but doesn't have a
 consensus?
 >
 > If this is indeed an issue, we'll have to fallback to testing the
 trusted dir list directly.

 If a directory authority doesn't have a consensus, then it can't serve any
 consensuses. And it will probably refuse to serve most other directory
 documents. So I think we're fine here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33029#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online