[tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Jan 26 21:19:15 UTC 2020


#30733: sbws does not detect changes in descriptor bandwidth values
-------------------------------------------------+-------------------------
 Reporter:  starlight                            |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:  sbws:
                                                 |  1.1.0
 Severity:  Critical                             |     Resolution:
 Keywords:  sbws-majority-blocker, sbws-         |  Actual Points:
  roadmap-august                                 |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:35 juga]:
 > When #30909 is merged, this ticket can be closed, since the remaining
 child tickets, #30747 and #30908 have been solved.

 I went through all the thread and realized there was a PR associated to
 this ticket:

 Replying to [comment:23 teor]:
 > I did a review of this pull request: the code looks good, but one of the
 comments is wrong.
 >
 > See my comment on the pull request:
 >
 https://github.com/torproject/sbws/pull/358/commits/2b3860678595dc8a1f26ab93bc6cef54fe796a7d#r294117174

 I squashed that PR, changed comments, cherry-picked the commits created
 other PR based on `maint-1.1`:
 https://github.com/torproject/sbws/pull/362

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list