[tor-bugs] #33041 [Core Tor/Chutney]: Chutney error message says to use 'TOR_DIR' instead of 'CHUTNEY_TOR'

[Tor Bug Tracker & Wiki]

#33041: Chutney error message says to use 'TOR_DIR' instead of 'CHUTNEY_TOR'
------------------------------+------------------------
 Reporter:  opara             |          Owner:  (none)
     Type:  defect            |         Status:  closed
 Priority:  Medium            |      Milestone:
Component:  Core Tor/Chutney  |        Version:
 Severity:  Normal            |     Resolution:  fixed
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------
Changes (by teor):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Thanks!

 I added some commits that:
 * fixed the wording of the usage advice (they are binary paths, not
 directory paths)
 * restored the test-network.sh usage advice alongside the chutney usage
 advice (we support both usage modes, and there's no way for test-
 network.sh to warn in this case)
 * checked for unknown tor_name, and raised an exception
 * improved comments and function documentation

 I also found an unrelated logging dict key typo bug during testing.

 If you put tickets in needs_review when you submit a pull request, we'll
 be able to find them more easily.

 Merged #32972, #33023, #32969, and #33041 together.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33041#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online