[tor-bugs] #33040 [Circumvention/Snowflake]: Minor Snowflake refactoring

[Tor Bug Tracker & Wiki]

#33040: Minor Snowflake refactoring
-----------------------------------------+----------------------
     Reporter:  dcf                      |      Owner:  dcf
         Type:  enhancement              |     Status:  assigned
     Priority:  Medium                   |  Milestone:
    Component:  Circumvention/Snowflake  |    Version:
     Severity:  Normal                   |   Keywords:
Actual Points:                           |  Parent ID:
       Points:                           |   Reviewer:
      Sponsor:                           |
-----------------------------------------+----------------------
 These are some minor improvements I made while reading through the code.
  * Removal of dead code and impossible conditional checks
  * Move logging to higher levels
  * Swap some yoda conditionals
  * Code and comment formatting
  * Channel `close` instead of `<-` to broadcast a signal

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33040>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online