[tor-bugs] #33006 [Core Tor/Tor]: Fix test-stem `test_take_ownership_via_controller` failure

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 23 17:25:45 UTC 2020


#33006: Fix test-stem `test_take_ownership_via_controller` failure
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  worksforme
 Keywords:  043-should    |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by catalyst):

 Replying to [comment:5 teor]:
 > It looks like this timing issue was introduced in the #30984 refactor,
 perhaps in commit c744d23c8d. (At least on my machine.)
 >
 > Tor doesn't guarantee control reply timing. And we're unlikely to be
 able to restore the old timing behaviour. So stem's tests should be
 adapted to work with the timing in both Tor 0.4.2 and Tor master.
 I'm not sure what that commit has to do with `TAKEOWNERSHIP`. It seems to
 be about `GETCONF` instead. Are you suggesting that a change to the timing
 or formatting of `GETCONF` is causing a specific stem test to consistently
 fail?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33006#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list