[tor-bugs] #32363 [Core Tor/Tor]: tor_inet_aton parsing of IPv4 literals is too lax

[Tor Bug Tracker & Wiki]

#32363: tor_inet_aton parsing of IPv4 literals is too lax
----------------------------------+------------------------------------
 Reporter:  liberat               |          Owner:  neel
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.4.1.6
 Severity:  Normal                |     Resolution:
 Keywords:  043-can               |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:  dgoulet, nickm, teor  |        Sponsor:
----------------------------------+------------------------------------
Changes (by dgoulet):

 * reviewer:  dgoulet => dgoulet, nickm, teor


Comment:

 One comment says: `This avoids using the heap.`.

 Now with the last changes, we do use the heap quite a bit with the
 `smartlist_t` so why would we prefer not using the heap in the first
 place? Does it still matter now?

 Apart from that, this looks OK to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32363#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online