[tor-bugs] #32883 [Core Tor/Tor]: Use tor_api.h entry points for ntmain.c
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Jan 17 06:31:01 UTC 2020
#32883: Use tor_api.h entry points for ntmain.c
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: .2
Reviewer: ahf | Sponsor:
--------------------------+------------------------------------
Changes (by teor):
* status: reopened => needs_revision
Comment:
Replying to [comment:9 nickm]:
> Maybe, given our release timeframe, we should consider reverting this in
0.4.3, and investigating more closely in 0.4.4?
Let's revert this change.
The revert might be complicated. I did an "ours" merge of #32778 to avoid
conflicts with the code in this ticket, which we now want to revert. Let's
make sure that #32778 ends up in master for 0.4.3, and this code does not.
Let's make a new PR that reverts PR 1635, and merges PR 1634.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32883#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list