[tor-bugs] #32962 [Core Tor/Tor]: add_c_file: bug when adding to end of include.am

[Tor Bug Tracker & Wiki]

#32962: add_c_file: bug when adding to end of include.am
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  043-should    |  Actual Points:  .3
Parent ID:                |         Points:  .1
 Reviewer:  catalyst      |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 I'm happy to change the asserts to raise ValueErrors instead, for
 consistency with the rest of the script.

 I'm also happy to change these checks to look for the Makefile.am. Seems
 like an easy mistake for a maintainer to make.

 I'll fix these once I'm back at my workstation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32962#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online