[tor-bugs] #27925 [Metrics/ExoneraTor]: Permanent link on /exonerator.html? is http

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jan 14 20:59:17 UTC 2020


#27925: Permanent link on /exonerator.html? is http
--------------------------------+------------------------------
 Reporter:  modik               |          Owner:  metrics-team
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:                      |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Alright, I wrote something with a base URL and relative links. Please
 review
 [https://gitweb.torproject.org/user/karsten/exonerator.git/commit/?h=task-27925&id=d165e4a1d5a29f82d932115e611011fc7ef97134
 ExoneraTor commit d165e4a in my task-27925 branch].

 If this gets merged and released, we'll only have to update the ExoneraTor
 version in metrics-web and include a base URL in its deployment descriptor
 as follows:

 {{{
 diff --git a/src/main/resources/web.xml b/src/main/resources/web.xml
 index 08a3bcd0..66cc3daa 100644
 --- a/src/main/resources/web.xml
 +++ b/src/main/resources/web.xml
 @@ -482,6 +482,10 @@
        /srv/metrics.torproject.org/metrics/website/rserve/graphs/
      </param-value>
    </context-param>
 +  <context-param>
 +    <param-name>baseUrl</param-name>
 +    <param-value>https://metrics.torproject.org</param-value>
 +  </context-param>

    <listener>
      <listener-class>
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27925#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list