[tor-bugs] #32434 [Applications/Tor Browser]: Get build changes needed for RLBox into tor-browser-build

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jan 13 07:22:21 UTC 2020


#32434: Get build changes needed for RLBox into tor-browser-build
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  project                              |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-security, GeorgKoppen202001,     |  Actual Points:
  TorBrowserTeam202001R                          |
Parent ID:  #32379                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-security, GeorgKoppen202001 => tbb-security,
     GeorgKoppen202001, TorBrowserTeam202001R
 * status:  new => needs_review


Comment:

 Okay, `bug_32389` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_32389) is a branch that produces a
 `libgraphitewasm.so` in Tor Browser. Thus, the build related parts (in
 child tickets) are good for review.

 I still need to go through all my browser patches and figure our why the
 built bundle is crashing. Moreover, I think the right way to treat this
 new feature is to put all the browser patches needed into `tor-browser-
 build`, too, as there are a lot of changes and they are pretty big. I
 would feel more comfortable if all of them are only applied if we build an
 RLBox enabled bundle. That work will happen #32389, though.

 (Setting this ticket in `needs_review` as all the child tickets and for a
 second pair of eyes for the approach described above.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32434#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list