[tor-bugs] #27268 [Applications/Tor Browser]: preferences cleanup

[Tor Bug Tracker & Wiki]

#27268: preferences cleanup
---------------------------------------------+-----------------------------
 Reporter:  rzb                              |          Owner:  gk
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff68-esr, TorBrowserTeam202001R  |  Actual Points:
Parent ID:                                   |         Points:  1
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by Thorin):

 Cool :) Looking at https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_27268_v4&id=469729e01aae49cbd4a571fb07fe240baa23f576

 from the list in comment 18

 {{{
 RFP redundant (4 of 6)
 -pref("dom.maxHardwareConcurrency", 1);
 -pref("ui.use_standins_for_native_colors", true);
 -pref("browser.zoom.siteSpecific", false);
 -pref("dom.enable_performance", false);

 RFP redundant part 2 (8 out of 8)
 -pref("general.appname.override", "Netscape");
 -pref("general.appversion.override", "5.0 (Windows)");
 -pref("general.oscpu.override", "Windows NT 6.1");
 -pref("general.platform.override", "Win32");
 -pref("general.productSub.override", "20100101");
 -pref("general.buildID.override", "20100101");
 -pref("general.useragent.vendor", "");
 -pref("general.useragent.vendorSub", "");

 RFP redundant part 3 (5 of 6)
 +pref("dom.netinfo.enabled", false);
 -pref("media.webspeech.synth.enabled", false);
 -pref("media.video_stats.enabled", false);
 -pref("dom.gamepad.enabled", false); // bugs.torproject.org/13023
 -pref("device.sensors.enabled", false);

 New (3 of 3)
 -pref("devtools.webide.autoinstallADBHelper", false);
 -pref("devtools.webide.autoinstallFxdtAdapters", false);
 +pref("devtools.webide.autoinstallADBExtension", false);
 }}}

 That all looks good. What's not addressed (or I don't understand): these
 are still being applied, but don't do anything: RFP already covers them
 - dom.enable_resource_timing
 - privacy.use_utc_timezone
 - privacy.suppressModifierKeyEvents

 I do not see any code upstream for the two `privacy.` prefs. And the
 resource timing is redundant (from part 1 in comment 18)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27268#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online