[tor-bugs] #32892 [Core Tor/Tor]: chan: Remove dead function command_process_var_cell()

[Tor Bug Tracker & Wiki]

#32892: chan: Remove dead function command_process_var_cell()
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  dgoulet
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-chan
Actual Points:                |  Parent ID:
       Points:  0.1           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 With `channel_set_cell_handlers()`, two handlers are set in a channel
 which are for fixed size cell and variable length cell.

 Turns out that the `channel->var_cell_handler` is never used since all var
 cell are processed through the channel TLS layer directly:

 `connection_or_process_cells_from_inbuf()`
  -> `channel_tls_handle_var_cell()`.

 Which means we can remove a good 70+ lines of dead code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32892>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online