[tor-bugs] #32880 [Core Tor/Tor]: V3 handshaking state change doesn't use "connection_or_change_state()"

[Tor Bug Tracker & Wiki]

#32880: V3 handshaking state change doesn't use "connection_or_change_state()"
--------------------------+------------------------------------
 Reporter:  opara         |          Owner:  dgoulet
     Type:  defect        |         Status:  accepted
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:  tor-chan      |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by opara):

 From a design/layer standpoint, it may be good to move the code that acts
 on the connection in {{{enter_v3_handshake_with_cell()}}} from
 {{{channeltls.c}}} to {{{connection_or.c}}} so that {{{channeltls.c}}}
 only needs to call something like
 {{{connection_or_init_server_v3_handshake()}}}. That way the channel
 doesn't need to worry about connection-specific things like renegotiation,
 updating the connection's internal state, initializing the connection's
 handshake state, etc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32880#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online