[tor-bugs] #32880 [Core Tor/Tor]: V3 handshaking state change doesn't use "connection_or_change_state()"

Mon Jan 6 05:47:06 UTC 2020

#32880: V3 handshaking state change doesn't use "connection_or_change_state()"
--------------------------+------------------------
 Reporter:  opara         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Low           |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Minor         |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------

Comment (by opara):

 It seems like when the function {{{connection_or_change_state()}}}
 [https://github.com/torproject/tor/commit/15303c32ec9d84aff8de5ed9df28e779c36c6e5c
 #diff-14050f3b8147e653d560de81d8cb77dfR315 was added to tor] in commit
 {{{15303c32}}}, the function was
 [https://github.com/torproject/tor/commit/15303c32ec9d84aff8de5ed9df28e779c36c6e5c
 #diff-14050f3b8147e653d560de81d8cb77dfL1616 used for the client state] in
 {{{connection_or.c}}}, but
 [https://github.com/torproject/tor/commit/15303c32ec9d84aff8de5ed9df28e779c36c6e5c
 #diff-55fee5f46caff0974e4fd74799bd95ccR1101 not the server state] in
 {{{channeltls.c}}}.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32880#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online