[tor-bugs] #32870 [Circumvention/Snowflake]: Bump version of pion webrtc in Tor Browser

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 2 21:44:18 UTC 2020


#32870: Bump version of pion webrtc in Tor Browser
-------------------------------------+------------------------------
 Reporter:  cohosh                   |          Owner:  cohosh
     Type:  task                     |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:  #31971                   |         Points:  1
 Reviewer:                           |        Sponsor:  Sponsor28
-------------------------------------+------------------------------
Changes (by cohosh):

 * status:  assigned => needs_review


Comment:

 Here's a commit to update the version of pion-webrtc to `v2.1.18`
 [https://gitweb.torproject.org/user/cohosh/tor-browser-build.git/commit/?h
 =pion-update&id=94477bee9250f33208e837d8021712e8ef590cd1 e8ef590cd1]

 The use of the
 [https://trac.torproject.org/projects/tor/attachment/ticket/28942/gomodtorbm
 script] from #28942 was actually relatively painless as most of the work
 has already been done and all that was left was add a few new projects and
 update the hashes of existing ones.

 I did make a small adjustment to script to account for a new versioning
 scheme used by pion-dtls. I just added another regex pattern to `tuple()`:
 {{{
     def tuple(self):
         m = re.match(r'^v([0-9]+)\.([0-9]+)\.([0-9]+)-(?:0\.)?([0-9]+)-([0
 -9a-fA-F]+)$', self.version)
         if m:
             g = m.groups()
             return int(g[0]), int(g[1]), int(g[2]), g[3], g[4]
         m = re.match(r'^v([0-9]+)\.([0-9]+)\.([0-9]+-rc\.[0-9]+)$',
 self.version)
         if m:
             g = m.groups()
             return int(g[0]), int(g[1]), g[2], "", ""
         m = re.match(r'^v([0-9]+)\.([0-9]+)\.([0-9]+)$', self.version)
         if m:
             g = m.groups()
             return int(g[0]), int(g[1]), int(g[2]), "", ""
         assert False, self.version
 }}}

 I then ran
 {{{
 $ checkout v2.1.18
 $ go mod graph | ./gomodtorbm
 }}}
 and copied the staging directory to `tor-browser-build/`.

 There were a few touchups needed to remove extraneous projects and expand
 the versions into git commit hashes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32870#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list