[tor-bugs] #28765 [Applications/Tor Browser]: LibEvent Build for Android

[Tor Bug Tracker & Wiki]

#28765: LibEvent Build for Android
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  sisbell
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm, tbb-parity,     |  Actual Points:
  TorBrowserTeam202002                           |
Parent ID:  #28704                               |         Points:  0.25
 Reviewer:  sysrqb, boklm                        |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:16 boklm]:


 > Replying to [comment:14 sisbell]:
 >
 > > Broke commit into its own branch, otherwise no changes since last
 commit.
 > >
 > > https://github.com/sisbell/tor-browser-build/commits/bug-28765
 > >
 >
 > When looking at commit f73f0125252cdf18596291c45ba3d92cb719b883:
 >
 > You define `var/configure_opt` to `--disable-static` in
 `project/libevent/config` for all platforms except android. I think this
 is wrong as `var/configure_opt` already has some values defined in
 `rbm.conf`, so we override those values which will probably break the
 build on non-android platforms.
 Ok that should be easy to fix.

 >
 >
 > By the way in ticket:28704#comment:14 I said this:
 >
 > > it seems we could have a var/configure_opt for android in `rbm.conf`
 containing something like `CC=clang --host=[% c("var/host") %] [%
 c("var/configure_opt_project") %]`, where `var/configure_opt_project` is
 defined in each project to define options specific to this project
 > >
 > I still think that would be a good idea. If you don't think so, then
 please at least explain why instead of just ignoring comments and not
 doing the changes suggested.

 I didn't ignore the comment. i previously stated the reason I didn't do it
 and requested more discussion around a solution.

 "There was a suggestion to move some of the fields in configure_opt up to
 rbm.  OpenSSL doesn't use the same configure_host value as other  projects
 so this will require some more discussion if we want to move  forward with
 this suggestion."

 https://trac.torproject.org/projects/tor/ticket/28704#comment:23
 >
 > Regarding update to version `2.1.11`, I think it would be a good idea to
 mention it in the commit message. Or maybe do it as a separate commit
 (with #31499 as the bug number) as this is a change that affect all
 platforms.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28765#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online