[tor-bugs] #33215 [Applications/Tor Browser]: Android Toolchain: Add NDK bin path to system path

[Tor Bug Tracker & Wiki]

#33215: Android Toolchain: Add NDK bin path to system path
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202002R                          |
Parent ID:  #28704                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by boklm):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:2 sisbell]:
 > Replying to [comment:1 sysrqb]:
 > > This is based on commit f5fdff3bf0b9e957ab011f95af9e215cca7aeed6 from
 ticket:28704#comment:23.
 > >
 > > {{{
 > > diff --git a/projects/android-toolchain/config b/projects/android-
 toolchain/config
 > > index 8c9c8222..4c02b2f3 100644
 > > --- a/projects/android-toolchain/config
 > > +++ b/projects/android-toolchain/config
 > > @@ -15,6 +15,7 @@ var:
 > >      export GRADLE_HOME=/var/tmp/dist/[% project %]/gradle
 > >      export ANDROID_HOME=$ANDROID_SDK_HOME
 > >      export GRADLE_USER_HOME=$GRADLE_HOME
 > > +    export PATH=$ANDROID_NDK_HOME/[% c("var/toolchain_arch")
 %]/bin:$PATH
 > > }}}
 > > If we put the toolchain at the end, are there situations where a
 system executable is used instead of the Android toolchain?
 >
 > I'll need to check old logs, but yes some projects just look for clang
 without the host info so it picks up the system executable for clang.

 In that case, it seems better to have the Android toolchain first in the
 PATH. Or are there any cases where we want a system executable to be used
 instead of the version from tho Android toolchain?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33215#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online