[tor-bugs] #33449 [Internal Services/Tor Sysadmin Team]: replace dsa_systemd with camptocamp systemd module

[Tor Bug Tracker & Wiki]

#33449: replace dsa_systemd with camptocamp systemd module
-----------------------------------------------------+-----------------
     Reporter:  anarcat                              |      Owner:  tpa
         Type:  task                                 |     Status:  new
     Priority:  Very Low                             |  Milestone:
    Component:  Internal Services/Tor Sysadmin Team  |    Version:
     Severity:  Major                                |   Keywords:
Actual Points:                                       |  Parent ID:
       Points:                                       |   Reviewer:
      Sponsor:                                       |
-----------------------------------------------------+-----------------
 we currently have two systemd module in Puppet, dsa_systemd (from the
 Debian sysadmins) and [https://github.com/camptocamp/puppet-systemd/
 camptocamp-systemd], from the Puppet forge.

 the latter was imported as a dependency of the Prometheus module and it
 would be very hard to remove it from our codebase.

 we should look at whether we can replace the dsa_systemd module with the
 forge systemd module instead. this would allow us to collaborate with a
 broader community and remove duplicate code from our monorepo.

 ideally, we'd also provide the good DSA folks a procedure on how to
 perform the migration, since we'll have to do it anyways.

 so far, I've found this transition:

 {{{
 dsa_systemd::linger { 'bridgescan': }
 }}}

 ... becomes:

 {{{
 loginctl_user { 'tordnsel':
     linger => enabled,
 }
 }}}

 we also use:

  * `dsa_systemd::override`
  * `dsa_systemd::mask`

 we already use the camptocamp:

  * `systemd::tmpfile`
  * `systemd::unit_file`

 ... and we have various systemd files manually deployed in `/lib` and
 `/etc`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33449>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online