[tor-bugs] #30196 [Core Tor/sbws]: Add the tor version to the sbws bandwidth file header

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Feb 24 22:43:56 UTC 2020


#30196: Add the tor version to the sbws bandwidth file header
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  enhancement    |         Status:  needs_review
 Priority:  High           |      Milestone:  sbws: 1.2.x-final
Component:  Core Tor/sbws  |        Version:
 Severity:  Major          |     Resolution:
 Keywords:  sbws-roadmap   |  Actual Points:
Parent ID:  #33121         |         Points:  1
 Reviewer:  ahf            |        Sponsor:
---------------------------+-----------------------------------

Comment (by teor):

 Sorry I forgot to put the ticket in needs_revision.

 I didn't put myself as reviewer, because I didn't want this ticket to
 block on me,

 I still think the variable naming is confusing: SELF_INITIALIZED, TO_INIT,
 and INT_KEYS are confusingly similar. And INITIALIZED and INIT are
 inconsistent.

 I'll leave you to decide if you want to fix that now, or open another
 ticket to fix it later.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30196#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list