[tor-bugs] #31180 [Core Tor/Tor]: Remove easy deprecated options in 0.4.4

[Tor Bug Tracker & Wiki]

#31180: Remove easy deprecated options in 0.4.4
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  task          |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  043-can       |  Actual Points:  .1
Parent ID:                |         Points:  2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:11 nickm]:
 > I don't think I've got the brainpower to remove
 `ClientPreferIPv6DirPort` right now, and I think we've missed the window
 where it's sensible to try this for 0.4.3.  Let's review what we've got in
 0.4.4, and maybe open a ticket for removing some more deprecated options
 if possible.

 I agree, it probably needs to happen early in 0.4.4. Or at the very least,
 before we do the IPv6 client work in proposal 306.

 Maybe coccinelle could help reduce the workload?
 We could get an initial patch by replacing
 options->ClientPreferIPv6DirPort with 0, and then removing {{{|| 0}}} and
 similar redundant constructs.

 As a second step, we can then simplify or rewrite a bunch of functions,
 but that doesn't need to happen straight away.

 (And now that clients only use ORPorts, their reachability decisions are
 between one IPv4 ORPort, and up to one IPv6 ORPort, which is a lot
 simpler. But that could be a third ticket.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31180#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online