[tor-bugs] #31011 [Core Tor/Tor]: Make the bridge authority reject private PT addresses when DirAllowPrivateAddresses is 0

[Tor Bug Tracker & Wiki]

#31011: Make the bridge authority reject private PT addresses when
DirAllowPrivateAddresses is 0
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  cjb
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-pt        |  Actual Points:
Parent ID:  #31009        |         Points:  1
 Reviewer:  ahf           |        Sponsor:  Sponsor28-can
--------------------------+------------------------------------

Comment (by cjb):

 Replying to [comment:22 teor]:
 > I did a quick review, and saw that the bridge authority is checking the
 address in the routerinfo, not the address in the ServerTransport line in
 the extrainfo,

 Oops, thanks!  Please could you point me towards a preferred way to access
 extrainfo lines from an `ei`?  I couldn't find any similar examples in the
 codebase.  So far I've found things like
 `router_parse_list_from_string()`, `signed_descriptor_get_body()`,
 `munge_extrainfo_into_routerinfo()` (deprecated).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31011#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online