[tor-bugs] #33367 [Circumvention/Snowflake]: Goroutine leak in websocketconn

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 20 04:46:30 UTC 2020


#33367: Goroutine leak in websocketconn
-------------------------------------+------------------------
 Reporter:  dcf                      |          Owner:  (none)
     Type:  defect                   |         Status:  closed
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:  fixed
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+------------------------

Comment (by dcf):

 Replying to [comment:11 cohosh]:
 > I would not be surprised if there were goroutine leaks in other parts of
 snowflake as well. We should take this opportunity to check the client,
 proxy-go, broker, and server for leaks.

 The pprof package has a
 [https://golang.org/pkg/runtime/pprof/#WriteHeapProfile WriteHeapProfile]
 analogous to the StartCPUProfile/StopCPUProfile from #33211. I haven't
 tried it but I found [https://www.freecodecamp.org/news/how-i
 -investigated-memory-leaks-in-go-using-pprof-on-a-large-codebase-
 4bec4325e192/ a blog post] about using it to find memory leaks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33367#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list