[tor-bugs] #33385 [Circumvention/Snowflake]: In server, treat a purported client IP address of 0.0.0.0 as missing

[Tor Bug Tracker & Wiki]

#33385: In server, treat a purported client IP address of 0.0.0.0 as missing
-----------------------------------------+----------------------
     Reporter:  dcf                      |      Owner:  dcf
         Type:  enhancement              |     Status:  assigned
     Priority:  Medium                   |  Milestone:
    Component:  Circumvention/Snowflake  |    Version:
     Severity:  Normal                   |   Keywords:
Actual Points:                           |  Parent ID:
       Points:                           |   Reviewer:
      Sponsor:                           |
-----------------------------------------+----------------------
 In #33157, proxies sometimes fail to extract a meaningful client IP
 address from the client's SDP and send `?client_ip=0.0.0.0` to the bridge.
 The bridge [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/server/server.go?h=webext-0.2.1#n113 counts]
 an address of 0.0.0.0 as a client that had an IP address, which inflates
 the numerator in the [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/server/stats.go?h=webext-0.2.1#n35 "in the
 past %.f s, %d/%d connections had client_ip"] log line.

 This is a patch to treat a client address of `0.0.0.0` or `[::]` as if it
 were not present at all.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33385>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online