[tor-bugs] #33368 [Core Tor/Tor]: Don't compile ext_orport.c when relay mode is disabled.

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Feb 19 17:13:29 UTC 2020


#33368: Don't compile ext_orport.c when relay mode is disabled.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:  .1
  2020Q1, 043-deferred library-size              |
Parent ID:  #31851                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Thanks for the review! I've added comments and moved functions per your
 comment above; once CI has passed, I'll merge.

 I've also opened #33383 because of my surprise about an unused function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33368#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list