[tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

[Tor Bug Tracker & Wiki]

#30733: sbws does not detect changes in descriptor bandwidth values
-------------------------------------------------+-------------------------
 Reporter:  starlight                            |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Very High                            |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:  sbws:
                                                 |  1.1.0
 Severity:  Critical                             |     Resolution:
 Keywords:  sbws-majority-blocker, sbws-roadmap  |  Actual Points:
Parent ID:  #33121                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Yes, changes in a ticket/PR does not mean at all changes in servers
 running that software. There is a whole/long process for it, which is very
 different to the 1-line scripts:
 https://trac.torproject.org/projects/tor/ticket/30733#comment:14

 There's a ticket specifically to check the descriptors update on live
 bwauths: https://trac.torproject.org/projects/tor/ticket/33198. Because we
 didn't "fiddle" enough with tests, at least not at correct time, when sbws
 started to be created.

 Regarding the bwauths:
 maatuska is running sbws from git, from a month ago, so it's 1.1.1-dev0,
 the patch in this ticket is not applied.
 longclaw is running from debian package, but patched to say version
 1.1.1-dev0
 (https://trac.torproject.org/projects/tor/ticket/30733#comment:25) and the
 patch in https://github.com/torproject/sbws/pull/358/, which is the same
 PR as in this ticked, except for the comments
 (https://trac.torproject.org/projects/tor/ticket/30733#comment:36)
 bastet is running sbws from debian package, so it's 1.1.0 and the patch in
 this ticket is not applied. But, it was restarted 1 day before teor did
 the count, maybe the reason descriptors were upgraded

 i totally agree we need to add the git commit hash to the version to avoid
 this confusion. Again that was already in
 https://trac.torproject.org/projects/tor/ticket/30733#comment:25

 It'd be great if your 1-line scripts, could become a maintanable software
 that shows the results to anyone and can be run by everyone, that's part
 of https://trac.torproject.org/projects/tor/ticket/30735, not 1-line
 script though. It was the same start of sbws...

 It should be a software that gets reviewed and double reviewed and gets
 tickets that were already closed reopened.

 i'm not commenting about unpoliteness nor rudeness cause i don't think
 that's a good use of my time, given my previous experiences.

 Last, but not least, not doing any effort on my "English"

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:51>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online