[tor-bugs] #33342 [Applications/Tor Browser]: Disconnect search addon causes error at startup

[Tor Bug Tracker & Wiki]

#33342: Disconnect search addon causes error at startup
------------------------------------------+--------------------------------
     Reporter:  sysrqb                    |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam202002
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 Following #32767, it seems Firefox is throwing an exception. I don't think
 it's too important.

 {{{
 1581718500372   addons.xpi-utils    WARN    addMetadata: Add-on
 disconnect at search.mozilla.org is invalid: Error: File resource://search-
 extensions/disconnect/ does not contain a valid
 manifest(resource://gre/modules/addons/XPIInstall.jsm:671:11) JS Stack
 trace: loadManifest at XPIInstall.jsm:671:11
 awaitPromise at XPIProvider.jsm:228:15
 syncLoadManifest at XPIInstall.jsm:750:24
 addMetadata at XPIDatabase.jsm:2721:32
 processFileChanges at XPIDatabase.jsm:3162:26
 getNewSideloads at XPIProvider.jsm:3005:28
 1581718500362   addons.xpi-utils    WARN    Not uninstalling invalid item
 because it is a proxy file
 }}}

 We may not need to do anything about this, but if there is a way we can
 prevent this error then that'll be even better (reducing noise in logging
 is helpful).

 acat, what do you think? I haven't looked at the code in the stacktrace at
 all.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33342>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online