[tor-bugs] #32622 [Core Tor/Tor]: Fix misleading STATUS_CLIENT warning message

[Tor Bug Tracker & Wiki]

#32622: Fix misleading STATUS_CLIENT warning message
-------------------------------------------------+-------------------------
 Reporter:  phw                                  |          Owner:
                                                 |  catalyst
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix anticensorship-wants        |  Actual Points:
  043-should                                     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by phw):

 Replying to [comment:6 catalyst]:
 > Replying to [ticket:32622 phw]:
 > > After Tor 0.4.3.0-alpha-dev successfully established a TCP connection
 with a bridge but failed to finish its handshake, it sends the following
 `STATUS_CLIENT` message to the controller:
 > > {{{
 > > 650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir
 SUMMARY="Finishing handshake with directory server" WARNING="DONE"
 REASON=DONE COUNT=1 RECOMMENDATION=warn
 HOSTID="0000000000000000000000000000000000000000" HOSTADDR="[scrubbed]"
 > > }}}
 >
 > Also, could you please confirm the affected tor versions?  I'm pretty
 sure the `handshake_dir` and `conn_dir` tags predate the bootstrap phase
 rename in 0.4.0 and no longer exist after that.
 >
 > I do see a similar problem on master, though, so it's worth further
 investigation in any case.
 [[br]]
 I can confirm that I'm seeing this with 0.4.3.0-alpha-dev. I just checked
 out master (currently 0.4.4.0-alpha-dev) and I'm seeing the same issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32622#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online