[tor-bugs] #33283 [Applications/rbm]: Add caching for the exec function in rbm

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Feb 12 18:30:30 UTC 2020


#33283: Add caching for the exec function in rbm
--------------------------------------------+------------------------------
 Reporter:  boklm                           |          Owner:  boklm
     Type:  task                            |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/rbm                |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam202002R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam202002R


Comment:

 In branch `bug_33283_v2`, I added two patches.

 The first one adds caching for the exec template function:
 https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_33283_v2&id=ce6b9136fc9e006536b34844946d67aa92cc0c21

 The second one avoids computing sha256sum of files multiple times:
 https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_33283_v2&id=e4f12abe9ed81050994b5345c21b988005259396

 When running the command `rbm/rbm showconf tor-browser filename --target
 torbrowser-linux-x86_64 --target alpha` on my machine, without those
 patches it takes 3m25. With the first patch, it now takes 2m49, and 1m59
 with both patches.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33283#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list