[tor-bugs] #33087 [Core Tor/Tor]: closing stdio fds on exit can interfere with LeakSanitizer, etc

[Tor Bug Tracker & Wiki]

#33087: closing stdio fds on exit can interfere with LeakSanitizer, etc
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.6
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-log, 043-should, consider-       |  Actual Points:  0.4
  backport-after-0433, 041-backport,             |
  042-backport                                   |
Parent ID:                                       |         Points:  0.2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 In fact, they'd be almost exactly like the issues we created by closing
 stderr early :-)

 Ok, I'll add fsync to configure, and use it when it's available. I think
 we should probably merge the fsync() fix to 0.4.3-alpha and later. fsync()
 is a very low risk function call.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33087#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online