[tor-bugs] #32193 [Core Tor/Tor]: update .gitlab-ci.yml to remove broken cruft and add a complete test suite

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 11 23:56:45 UTC 2020


#32193: update .gitlab-ci.yml to remove broken cruft and add a complete test suite
-------------------------------------------------+-------------------------
 Reporter:  eighthave                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, gitlab-ci, tor-ci, 043-can  |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:  hiro, catalyst                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by catalyst):

 Replying to [comment:15 eighthave]:
 > Sorry, I don't remember any details at this point, its been a few
 months.

 Thanks.  Based on my observations, it's currently not a problem on master.

 The changes that parameterize the Debian-based builds using templates
 mostly look good.  I'll need to look a bit more closely at them and learn
 more about how templates work on GitLab.

 There are some choices you made that might not be appropriate to our
 repository.  I'll try to figure out which they are and try to ask about
 your rationale for them.  Also I'll try to determine whether they're
 appropriate choices for us.  We might not accept your patches as-is, but
 it seems somewhat likely that we'll use something based on them (with
 credit to you, of course).

 I've asked someone on the Tor Browser team to take a look at the Android
 work when they get a chance.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32193#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list