[tor-bugs] #32193 [Core Tor/Tor]: update .gitlab-ci.yml to remove broken cruft and add a complete test suite

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 11 16:16:59 UTC 2020


#32193: update .gitlab-ci.yml to remove broken cruft and add a complete test suite
-------------------------------------------------+-------------------------
 Reporter:  eighthave                            |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  Android, gitlab-ci, tor-ci, 043-can  |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:  hiro, catalyst                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by catalyst):

 Replying to [comment:8 eighthave]:
 > If you push the existing .gitlab-ci.yml to any gitlab.com fork, you will
 see that the CI job results in a broken build.  In my fork, you can see
 the jobs working.  Each job has a full log, that is literally just a log
 of the bash script running, e.g. the `script:` sections of .gitlab-ci.yml

 You mentioned this earlier.  I don't see evidence of such build failures
 when I push stuff to gitlab.com.  See the successful build at
 https://gitlab.com/argonblue/tor/-/commits/ticket33213 for example.  That
 is literally your pull request branch rewound to only include the
 mirroring job removal commit and one additional commit to add a changes
 file.

 I would like to prioritize the remaining patches based on knowing how
 broken the .gitlab-ci.yml is after removing the mirroring job.  Would you
 please tell us what kinds of failures you experienced with .gitlab-ci.yml
 that are attributable to the version of that file that is on master?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32193#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list