[tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Feb 10 17:00:15 UTC 2020


#32921: Code and script changes to run clang-format without breaking checkSpaces or
coccinelle
----------------------------+------------------------------------
 Reporter:  nickm           |          Owner:  nickm
     Type:  enhancement     |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  style, 043-can  |  Actual Points:  1.5
Parent ID:  #29226          |         Points:
 Reviewer:  catalyst        |        Sponsor:
----------------------------+------------------------------------

Comment (by catalyst):

 Replying to [comment:17 nickm]:

 > I agree with combining `dummy_semicolon_eater__` and
 `tor_semicolon_eater`.  The trouble with `ht.h` is that it's in src/ext,
 so we don't technically "own" it: we try to keep it usable outside of Tor.
 That said, we can create an `ht_semicolon_eater` for ht.h.

 Let's open an independent ticket for combining the two existing dummy
 struct tags.  I agree we can make a `ht_semicolon_eater` specifically for
 ht.h.

 > Let me know if you'd like me to do the StatementMacros removal in this
 branch or open a new ticket.

 I think both `ht_semicolon_eater` and removing `StatementMacros` can be in
 this branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32921#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list