[tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

[Tor Bug Tracker & Wiki]

#19026: Remove local LAN address ICE candidates
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  arlolra
     Type:  enhancement              |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+------------------------------

Comment (by dcf):

 Replying to [comment:17 arlolra]:
 > It could, but since `offer *webrtc.SessionDescription` comes from a call
 to `pc.LocalDescription()`, I didn't want to invalidate the cached parsed
 description in that structure,
 > https://github.com/pion/webrtc/blob/master/sessiondescription.go#L10-L13
 >
 > You could skip it, yes, but I felt the cheap string check was preferable
 attempting a parse,
 >
 https://github.com/pion/sdp/blob/03441e3c706c7c3b719ee75194049a31cbb2eb7e/common_description.go#L112-L122

 Okay, works for me.

 > Yeah, that was ugly.  I pushed commit for this suggestion,
 >
 https://github.com/keroserene/snowflake/commit/edd53af92ac868cf3ba57988e14de887f088a47b

 Everything looks good from my point of view.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19026#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online