[tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Feb 7 14:21:25 UTC 2020


#32921: Code and script changes to run clang-format without breaking checkSpaces or
coccinelle
----------------------------+------------------------------------
 Reporter:  nickm           |          Owner:  nickm
     Type:  enhancement     |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  style, 043-can  |  Actual Points:  1.5
Parent ID:  #29226          |         Points:
 Reviewer:  catalyst        |        Sponsor:
----------------------------+------------------------------------

Comment (by nickm):

 I've pushed a new rebased `clang_format_prep_3`, which is the branch I am
 hoping for review on here.  This branch forces no formatting per se, and
 only prepares for formatting.  https://github.com/torproject/tor/pull/1709
 is the pull request.  There's a CI failure, but it looks like a download
 failure rather than a real bug.

 https://github.com/torproject/tor/pull/1710 is the result of running
 clang-format.sh on that branch. The CI failures are real there due to some
 functions getting longer and making practracker upset.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32921#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list