[tor-bugs] #19026 [Circumvention/Snowflake]: Remove local LAN address ICE candidates

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Feb 7 01:58:12 UTC 2020


#19026: Remove local LAN address ICE candidates
-------------------------------------+--------------------------------
 Reporter:  dcf                      |          Owner:  arlolra
     Type:  enhancement              |         Status:  needs_revision
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+--------------------------------

Comment (by arlolra):

 Ok, new commit at
 https://github.com/keroserene/snowflake/commit/dbd133b6e1196e4ec7550f0ebb52854cb00d1007

 > Some comments:
 >
 > - {{{FIXME: Should this check ip.IsLoopback() and others?}}} I'd like to
 include `0.0.0.0` and `127.0.0.1` addresses in this, especially after dcf
 found #33157.

 The condition now looks like `IsLocal(ip) || ip.IsUnspecified() ||
 ip.IsLoopback()`, which includes these addresses.

 > - Let's expand the tests and include one for each type of local address

 Done

 > - It's worth implementing this for each of the proxies as well.

 Can this be a follow up?

 > - Is there a way for us to use the other built-in functions in the `net`
 package for determining whether or not the IP address is local?

 Not that I'm aware of.  The included function was referenced from,
 https://github.com/golang/go/issues/29146

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19026#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list