[tor-bugs] #19757 [Applications/Tor Browser]: Make a menu to add onion and auth-cookie to TB

[Tor Bug Tracker & Wiki]

#19757: Make a menu to add onion and auth-cookie to TB
-------------------------------------------------+-------------------------
 Reporter:  mrphs                                |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-usability, tor-hs,      |  Actual Points:  6.5
  TorBrowserTeam202002R                          |
Parent ID:  #30000                               |         Points:  8
 Reviewer:  pospeselr, acat                      |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by mcs):

 * status:  needs_revision => needs_review
 * keywords:  ux-team, tbb-usability, tor-hs, TorBrowserTeam202001 => ux-
     team, tbb-usability, tor-hs, TorBrowserTeam202002R


Comment:

 We rebased our patches to sit on top of the #30237 commits that sysrqb
 merged, fixed the `controllerFailureMsg` issue that acat found
 (comment:31), and used eslint to find and fix various style issues in the
 new JS files (we should separately decide as a team if we want to run all
 of our existing JS files through eslint, e.g., the other files under
 `browser/components/onionservices`).

 Kathy and I think this is ready to merge now. One final thing to consider
 is whether it would be easier to maintain the #30237 tor-browser patch and
 the patch for this ticket if they were merged together; that is, should we
 handle the tor-browser patch for this ticket as a fixup commit to the
 #30237 one?

 Here are the new patches (all are on `bug19757-02` branches within brade's
 various repos):

 Torbutton strings:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19757-02&id=fddbe371f2eb43d7d6007561db38d1ad8a6ff8e4

 Torbutton control port module enhancements:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug19757-02&id=dc1871601fad289645696bb8138e8b14c46dd60a

 Tor Launcher string:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug19757-02&id=f53497c7255b040b6c97738c3c64e98b69cc96e4

 Tor Launcher enhancement to create an onion-auth directory for storage of
 the keys:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug19757-02&id=6ceda2e5565702f13933b83653c1951789fc0252

 Tor Browser changes ("Remember this key" checkbox plus about:preferences
 changes):
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug19757-02&id=06f115cc028e27124b48b40aaa83e988c28a9d98

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19757#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online