[tor-bugs] #33029 [Core Tor/Tor]: dir-auth: Dir auths should resume sending 503's but never to relays or other dir auths

[Tor Bug Tracker & Wiki]

#33029: dir-auth: Dir auths should resume sending 503's but never to relays or
other dir auths
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  defect                   |         Status:  needs_review
 Priority:  Medium                   |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  tor-dirauth 043-should?  |  Actual Points:
Parent ID:  #33018                   |         Points:  0.4
 Reviewer:  nickm, armadev           |        Sponsor:
-------------------------------------+------------------------------------

Comment (by nickm):

 For mysterious reasons, github isn't letting me commetn right now, so I'm
 going to have to do the comments here, old-school.

 On `dirlist: Add configured trusted dir to the nodelist address set`:
    * We should rename `dirlist_add_trusted_addresses()`.  It makes it
 sound like the addresses themselves are trusted, but we don't actually
 trust the addresses: they are just the addresses of trusted dirauths.  We
 don't want somebody else down the line think that these addresses are
 automatically trusted.

 Otherwise this looks correct to me!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33029#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online