[tor-bugs] #32542 [Core Tor/Tor]: hs-v3: Add the 2 missing SOCKS extended errors from prop304

[Tor Bug Tracker & Wiki]

#32542: hs-v3: Add the 2 missing SOCKS extended errors from prop304
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, 043-can, network-team-       |  Actual Points:  0.4
  roadmap-2020Q1                                 |
Parent ID:  #14389                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Looking good but I pointed out a few stuff on the PR.

 Also the fact that this hasn't been tested in real life makes me a bit
 anxious that things might crash or not work as intended. We could at least
 test the introduction F2 by shutting down the service in a chutney
 network, and having the client download the descriptor and trying to
 connect to it (all intros would send NACKs).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32542#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online