[tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

[Tor Bug Tracker & Wiki]

#30733: sbws does not detect changes in descriptor bandwidth values
-------------------------------------------------+-------------------------
 Reporter:  starlight                            |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Very High                            |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:  sbws:
                                                 |  1.1.0
 Severity:  Critical                             |     Resolution:
 Keywords:  sbws-majority-blocker, sbws-roadmap  |  Actual Points:
Parent ID:  #33121                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:42 juga]:
 > Replying to [comment:41 asn]:
 > Questions about the dormant mode:
 > - could tor become dormant when it is constantly creating new circuits?.

 Tor should not become dormant if it is constantly creating new circuits.
 If a sbws tor goes dormant, then:
 * there is a bug in sbws, or
 * there is a bug in tor.

 So if a sbws tor becomes dormant, we should look for bugs in sbws or tor.

 Does sbws stop trying to make circuits if:
 * the network goes down?
 * tor doesn't have a recent consensus or descriptors?

 If sbws does do these things, then tor might go dormant. So we should fix
 these bugs. (But they are not urgent.)

 > - would be enough to set the option `DormantCanceledByStartup 1` to
 ensure that tor won't ever become dormant?

 No, `DormantCanceledByStartup 1` only cancels dormant mode when tor is
 restarted.

 What does sbws do when it starts with a dormant tor? Does it still work?

 If it doesn't, we should set `DormantCanceledByStartup 1`, until we fix
 the dormant bugs in sbws.

 > - in which tor version was introduced the dormant mode?, 0.4.0?

 Tor 0.4.0.4-rc.

 > Maybe i could create other ticket to test this once we also run tests
 with different tor versions (#30067)?

 Good idea!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online