[tor-bugs] #32673 [Core Tor/Tor]: 'buf_read_from_tls()' can return the wrong error code

[Tor Bug Tracker & Wiki]

#32673: 'buf_read_from_tls()' can return the wrong error code
-------------------------------------------------+-------------------------
 Reporter:  opara                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.4-rc
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-tls, tor-security, consider-     |  Actual Points:  .1
  backport-if-needed, consider-backport-         |
  after-0433, 035-backport, 040-backport,        |
  041-backport, 042-backport fast-fix            |
  043-should                                     |
Parent ID:                                       |         Points:  1
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:10 arma]:
 > Replying to [comment:8 nickm]:
 > > marking for possible backport.  Note that I'm not so sure about a
 backport here: any behavioral changes that this patch causes will be
 subtle indeed, and perhaps best not backported unless we are certain they
 are beneficial.
 >
 > "We don't know of any actual behavior this will fix" plus "we're not
 sure if the patch introduces surprises" sound together like a great
 rationale for not backporting. Or for leaving the ticket in limbo (open
 but not backported) until it becomes clearer that we should backport it or
 close it.

 This ticket is tagged with `consider-backport-if-needed`.

 I use the tag `consider-backport-if-needed` for tickets which we're not
 sure if we want to backport:
 https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/Backports#WaitingtoseeifaBackportisNeeded

 I won't backport those tickets, and no-one else should, either:
 https://trac.torproject.org/projects/tor/wiki/user/teor#Backports

 (If someone thinks there are good reasons for backporting a `consider-
 backport-if-needed`, they should double-check with me and Nick.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32673#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online