[tor-bugs] #33097 [Core Tor/Tor]: outbuf_flushlen seems to serve no purpose

[Tor Bug Tracker & Wiki]

#33097: outbuf_flushlen seems to serve no purpose
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 outbuf_flushlen is for exactly what you described: "how much of the outbuf
 should we attempt to flush now?" The outbuf could be arbitrary-sized, for
 example if a pile of cells came in but the corresponding place to send
 them to is blocked. And so when that destination unblocks, we don't just
 want to write the entire outbuf to the network right then, because it
 could be unfair to the other places that also want to write, especially if
 it uses up our write tokens and we stop wanting to flush anything else.

 If we now do all of that using other logic, sounds great.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33097#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online