[tor-bugs] #33835 [Circumvention/BridgeDB]: Gmail's quoted response confuses BridgeDB's email autoresponder

[Tor Bug Tracker & Wiki]

#33835: Gmail's quoted response confuses BridgeDB's email autoresponder
------------------------------------+--------------------------------
 Reporter:  phw                     |          Owner:  agix
     Type:  defect                  |         Status:  needs_revision
 Priority:  Medium                  |      Milestone:
Component:  Circumvention/BridgeDB  |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  s30-o22a2               |  Actual Points:
Parent ID:  #31279                  |         Points:  1
 Reviewer:                          |        Sponsor:  Sponsor30-can
------------------------------------+--------------------------------
Changes (by phw):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:11 agix]:
 > There you go:
 >
 [https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e]
 >
 > Correction about comment:8
 > What I meant was that all but 4 unit tests (and a few commented out
 ones) pass :)
 [[br]]
 Thanks! I left a bunch of comments
 [https://github.com/agiix/bridgedb/commit/1fb531ed505352026223c298607554654116564e
 here]. The overall approach seems reasonable but we should make a handful
 of small changes – I'm happy to elaborate on any of my comments, just let
 me know. I would also suggest to not worry about the unit tests for now.
 Let's make sure that we're happy with the overall design, and then we can
 make sure that everything is properly tested.

 Finally, please don't feel discouraged by my asking for revisions. Non-
 trivial patches (and this certainly is one) typically go through at least
 one round of revisions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33835#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online