[tor-bugs] #32910 [Core Tor/Tor]: trace: Add tracepoints and userspace tracer support

[Tor Bug Tracker & Wiki]

#32910: trace: Add tracepoints and userspace tracer support
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tracing       |  Actual Points:
Parent ID:                |         Points:  3
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This code is looking a lot better now.  I think that all we need is the
 documentation, testing, and some quick feedback from the research safety
 folks.  I've also left a couple of cosmetic comments on gihub.

 For testing: We may need a CI option that builds with instrumentation
 turned on, but it would also be necessary to have tests that make sure
 that the trace events are generated.  I didn't see those tests here yet.

 For documentation, I don't feel too strongly about _where_ we put it -- I
 had been thinking that it might go in the files where we define the events
 -- but some kind of independent document would be fine too.  If we do a
 separate document, however, we should think about how to make sure that it
 stays in sync with the trace events.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32910#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online